Skip to content

Conversation

@xlc
Copy link
Contributor

@xlc xlc commented Dec 3, 2025

Closes #10512

@bkchr bkchr added the T9-cumulus This PR/Issue is related to cumulus. label Dec 3, 2025
@xlc
Copy link
Contributor Author

xlc commented Dec 3, 2025

/cmd prdoc

@xlc
Copy link
Contributor Author

xlc commented Dec 3, 2025

/cmd fmt

@bkchr bkchr enabled auto-merge December 3, 2025 21:51
@iulianbarbu iulianbarbu disabled auto-merge December 4, 2025 08:12
@iulianbarbu
Copy link
Contributor

iulianbarbu commented Dec 5, 2025

check-umbrella needs fixing too. You'd need to add the crate into the umbrella/polkadot-sdk crate, as a dependency, in a similar fashion to parachains-common crate (in Cargo.toml and lib.rs).

@xlc
Copy link
Contributor Author

xlc commented Dec 5, 2025

Updated. It doesn't make a lot of sense to put this to umbrella but anyway...
Also we should have something like /cmd umbrella to do it like prdoc

@iulianbarbu iulianbarbu added this pull request to the merge queue Dec 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2025
@iulianbarbu iulianbarbu enabled auto-merge December 8, 2025 10:05
@iulianbarbu iulianbarbu added this pull request to the merge queue Dec 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025
@iulianbarbu
Copy link
Contributor

Looks like the PR couldn't be merged. Main error being related to check-publish-compile: https://github.com/paritytech/polkadot-sdk/actions/runs/20030408485/job/57437953739. Updated the branch to latest master, to see if the error reproduces with latest changes in master.

@iulianbarbu iulianbarbu enabled auto-merge December 8, 2025 17:05
@iulianbarbu iulianbarbu added this pull request to the merge queue Dec 11, 2025
Merged via the queue into paritytech:master with commit 05fd451 Dec 11, 2025
225 of 230 checks passed
@xlc xlc deleted the parachains-common-types branch December 11, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T9-cumulus This PR/Issue is related to cumulus.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduce footprint of polkadot-omni-node-lib

3 participants