Skip to content

Conversation

@paritytech-release-backport-bot

Backport #10390 into stable2512 from bkchr.

See the documentation on how to use this bot.

…as decoded from (#10390)

This pull request ensures that when decoding an `UncheckedExtrinsic`
from a certain byte string, it also encodes to the same byte string.
This is achieved by keeping the original bytes used to decode the `call`
around and then directly encode these.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
(cherry picked from commit 2492fc8)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 3, 2025
@github-actions github-actions bot requested a review from bkchr December 3, 2025 10:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

This change ensures that decoding an `UncheckedExtrinsic` from a specific byte string correctly encodes back to the same byte string by retaining the original bytes used for decoding.
@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) December 4, 2025 08:45
@EgorPopelyaev EgorPopelyaev merged commit 33927ee into stable2512 Dec 9, 2025
256 of 267 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-10390-to-stable2512 branch December 9, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants