-
Notifications
You must be signed in to change notification settings - Fork 1.1k
revive eth-rpc Add polkadot_postDispatchWeight rpc methods #10612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding a new method to return the post-dispatch weight of a transaction
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
|
/cmd fmt |
Differential Tests Results (PolkaVM)Specified Tests
Counts
FailuresThe test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information Detailed Differential Tests Failure Information
|
Differential Tests Results (REVM)Specified Tests
Counts
FailuresThe test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information Detailed Differential Tests Failure Information
|
athei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename substrate to polkadot. The former is kind of a legacy name.
As per review feedback, rename `substrate` to `polkadot` throughout the newly added RPC methods since substrate is a legacy name. Changes: - Renamed substrate_api.rs to polkadot_api.rs - Renamed trait SubstrateRpc to PolkadotRpc - Renamed method substrate_postDispatchWeight to polkadot_postDispatchWeight - Renamed struct SubstrateRpcServerImpl to PolkadotRpcServerImpl - Updated prdoc title 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/bot fmt |
|
/cmd fmt |
Add a new RPC method to return the post-dispatch weight of a transaction