statement-store: use many workers for network statements processing #10617
Conversation
AndreiEres
changed the base branch from
master
to
AndreiEres/latency-benchmark
AndreiEres
added
the
R0-no-crate-publish-required
AndreiEres
force-pushed
the
AndreiEres/sss-many-workers
branch
from
ca01bb3 to
0d5c79f
Compare
AndreiEres
changed the base branch from
AndreiEres/latency-benchmark
to
master
AndreiEres
removed
the
R0-no-crate-publish-required
AndreiEres
changed the title
|
/cmd prdoc --audience node_user --bump minor |
|
Command "prdoc --audience node_user --bump minor" has failed ❌! See logs here |
|
prdoc --audience node_dev,node_operator --bump minor |
|
/cmd prdoc --audience node_dev,node_operator --bump minor |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
There was a problem hiding this comment.
Looks good to me!
| if num_validation_workers == 0 { | ||
| log::warn!( | ||
| target: LOG_TARGET, | ||
| "num_validation_workers is 0, defaulting to 1" |
There was a problem hiding this comment.
I'm going to carp a little about the naming; maybe it's just my PVF-oriented thinking, but "validation worker" sounds to me like it's related to candidate validation, and that would be my first thought if I saw that line in the logs. Probably it's better to stick with "statement validation workers" or something?
Description
Fixes #10814
Adds --statement-network-workers CLI parameter to enable concurrent statement validation from the network. Previously, statements were validated sequentially by a single worker. This change allows multiple workers to process statements in parallel, improving throughput when statement store is enabled
Integration
Non-breaking change with opt-in performance improvement. Default behavior unchanged (single worker).