Skip to content

[stable2512] Backport #10616 #10655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorPopelyaev merged 2 commits into from
Dec 16, 2025
Merged

[stable2512] Backport #10616 #10655

EgorPopelyaev merged 2 commits into from
Dec 16, 2025

Conversation

@paritytech-release-backport-bot
Copy link

@paritytech-release-backport-bot paritytech-release-backport-bot bot commented Dec 15, 2025

Backport #10616 into stable2512 from lexnv.

See the documentation on how to use this bot.

@lexnv @github-actions
relay-sproof-builder/test: Fix num of descendants (#10616)
8e0fc35 
This PR fixes a testing off-by-one error which causes the
`sproof-builder` to build an extra descendant.

While at it, have added a few detailed tests to double-check that the
proper number of headers is produced.

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ec03705)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 15, 2025
@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Dec 15, 2025
Merged
@github-actions github-actions bot requested a review from lexnv December 15, 2025 20:46
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) December 16, 2025 08:37
@EgorPopelyaev EgorPopelyaev merged commit 424cdfa into stable2512 Dec 16, 2025
218 of 226 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-10616-to-stable2512 branch December 16, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez approved these changes

@lexnv lexnv lexnv approved these changes

Assignees

No one assigned

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggwpez @lexnv @EgorPopelyaev