[pallet-assets] add ForeignAssetIdExtractor to assets precompile #10869

0xRVE · 2026-01-22T09:46:34Z

fixes #8659

Adds ForeignAssetIdExtractor which converts a u32 asset id to an XCM Location type.

This reverts commit dc1b49d.

0xRVE · 2026-01-22T09:50:02Z

/cmd prdoc --audience runtime_dev --bump minor

…time_dev --bump minor'

…ch/polkadot-sdk into rve/8659-assets-precompile

substrate/frame/assets/precompiles/src/foreign_assets.rs

prdoc/pr_10869.prdoc

substrate/frame/assets/precompiles/src/foreign_assets.rs

acatangiu · 2026-01-22T10:16:08Z

Another general comment is that it needs more tests (easy to use Claude for writing tests fast).

0xRVE · 2026-01-23T15:08:28Z

Another general comment is that it needs more tests (easy to use Claude for writing tests fast).

done

0xRVE · 2026-01-29T14:44:13Z

/cmd bench --runtime dev --pallet pallet_assets_precompiles

github-actions · 2026-01-29T14:45:09Z

Command "bench --runtime dev --pallet pallet_assets_precompiles" has started 🚀 See logs here

github-actions · 2026-01-29T15:18:29Z

Command "bench --runtime dev --pallet pallet_assets_precompiles" has failed ❌! See logs here

0xRVE · 2026-01-30T08:55:31Z

/cmd bench --runtime dev --pallet pallet_assets_precompiles

github-actions · 2026-01-30T08:56:20Z

Command "bench --runtime dev --pallet pallet_assets_precompiles" has started 🚀 See logs here

…--pallet pallet_assets_precompiles'

github-actions · 2026-01-30T09:29:09Z

Command "bench --runtime dev --pallet pallet_assets_precompiles" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	New	Change [%]
substrate/frame/assets/precompiles/src/weights.rs	migrate_asset_step_skip	7.70us	Added
substrate/frame/assets/precompiles/src/weights.rs	migrate_asset_step_migrate	8.63us	Added
substrate/frame/assets/precompiles/src/weights.rs	migrate_asset_step_finished	4.59us	Added

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_assets_precompiles']

substrate/frame/assets/precompiles/src/foreign_assets.rs

substrate/frame/assets/precompiles/src/foreign_assets_tests.rs

pgherveou · 2026-01-30T10:30:30Z

substrate/frame/assets/precompiles/src/migration.rs

+///
+/// # Safety
+///
+/// - Idempotent: Skips assets that already have mappings


the mapping didn't exist before the migration, so I don't see why we need to specify this?

Maybe I dont understand the way migrations work, but this is what I thought:
The migration runs on runtime upgrades. Which means this migration will run several time in the future. So running it twice on the same set of foreign assets should not change anything. So it is required to be idempotent.

no once they are passed they don't re-run

see

polkadot-sdk/substrate/frame/migrations/src/lib.rs

Lines 52 to 61 in 02f16b7

//! ### Design Goals

//!

//! 1. Must automatically execute migrations over multiple blocks.

//! 2. Must expose information about whether migrations are ongoing.

//! 3. Must respect pessimistic weight bounds of migrations.

//! 4. Must execute migrations in order. Skipping is not allowed; migrations are run on a

//! all-or-nothing basis.

//! 5. Must prevent re-execution of past migrations.

//! 6. Must provide transactional storage semantics for migrations.

//! 7. Must guarantee progress.

substrate/frame/assets/precompiles/src/migration.rs

substrate/frame/assets/precompiles/src/migration_benchmarks.rs

pgherveou · 2026-01-30T10:38:01Z

substrate/frame/assets/precompiles/src/migration_benchmarks.rs

+		}
+	}
+
+	/// Benchmark the case when there are no more assets to iterate.


can be removed as well, it's fine to over-estimate for the last step

substrate/frame/assets/precompiles/src/tests.rs

pgherveou · 2026-01-30T11:23:13Z

substrate/frame/assets/precompiles/src/foreign_assets.rs

+	pub trait Config: frame_system::Config {
+		/// The foreign asset ID type. This must match the `AssetId` type used by the
+		/// `pallet_assets` instance for foreign assets.
+		type ForeignAssetId: Member + Parameter + Clone + MaybeSerializeDeserialize + MaxEncodedLen;


I really think we should simplify where we can and not use an associated type here where we can hardcode it to Location, will test what it looks like without it

@franciscoaguirre what do you think ? or maybe it's annoying because we need to update the Location version everytime you bump it here

580 impl pallet_assets::Config<ForeignAssetsInstance> for Runtime { 1 ▎ type RuntimeEvent = RuntimeEvent; 2 ▎ type Balance = Balance; 3 ▎ type AssetId = xcm::v5::Location;

tasked Claude with it here #10945
also @franciscoaguirre Location encoding is stable ? if AH use v6 in a couple of month would an existing Location encode to the same value (I assume yes)

substrate/frame/assets/precompiles/src/foreign_assets.rs

pgherveou · 2026-01-30T13:51:31Z

substrate/frame/assets/precompiles/src/foreign_assets.rs

+	/// Mapping an asset index (derived from the precompile address) to a `ForeignAssetId`.
+	#[pallet::storage]
+	pub type AssetIndexToForeignAssetId<T: Config> =
+		StorageMap<_, Blake2_128Concat, u32, T::ForeignAssetId, OptionQuery>;


I would use Identity here instead of Blake2_128Concat since the system control the keys (they are incrementing by one for each insert )

pgherveou · 2026-01-30T14:08:55Z

substrate/frame/assets/precompiles/src/foreign_assets.rs

+	#[pallet::pallet]
+	pub struct Pallet<T>(_);
+
+	/// The next available asset index for foreign assets.


I don't think we need anything pub in this pallet, all we need is the AssetsCallback and the ForeignAssetIdExtractor that I will keep in that module to keep everything private

Was able to remove a few pubs

pgherveou · 2026-01-30T14:18:58Z

substrate/frame/assets/precompiles/src/migration.rs

+
+const PRECOMPILE_MAPPINGS_MIGRATION_ID: &[u8; 32] = b"foreign-asset-precompile-mapping";
+
+/// Progressive states of the precompile mappings migration.


I don't think you need that
you can just do

type Cursor = <T as pallet_assets::Config>::AssetId;

or Location directly if we stop using generic

Not sure what you mean here, can you elaborate?

we don't need the MigrationState we can just use A

substrate/frame/assets/precompiles/src/migration.rs

pgherveou · 2026-01-30T14:22:56Z

substrate/frame/assets/precompiles/src/lib.rs

+pub use migration::{MigrateForeignAssetPrecompileMappings, MigrationState};
+pub use weights::{SubstrateWeight, WeightInfo as MigrationWeightInfo};


not sure we need all thes extra pub if you have already made the module pub

substrate/frame/assets/precompiles/src/migration_benchmarks.rs

pgherveou · 2026-01-30T16:31:51Z

substrate/frame/assets/precompiles/src/foreign_assets.rs

+	/// Mapping a `ForeignAssetId` to an asset index (used for deriving precompile addresses).
+	#[pallet::storage]
+	pub type ForeignAssetIdToAssetIndex<T: Config> =
+		StorageMap<_, Identity, T::ForeignAssetId, u32, OptionQuery>;


this one should probably still need a hash though since you could craft Location that make the trie unbalanced

pgherveou · 2026-01-30T16:34:55Z

substrate/frame/assets/precompiles/src/weights.rs

+		// Minimum execution time: 8_247_000 picoseconds.
+		Weight::from_parts(8_630_000, 0)
+	}
+	fn migrate_asset_step_skip() -> Weight {


re-run the bot to get these methods removed

pgherveou

After addressing last comments.
Would also prefer to not have this Generic since we know that this is targeting Location

0xRVE · 2026-01-30T17:52:20Z

/cmd bench --runtime dev --pallet pallet_assets-precompiles

github-actions · 2026-01-30T17:53:05Z

Command "bench --runtime dev --pallet pallet_assets-precompiles" has started 🚀 See logs here

github-actions · 2026-01-30T18:25:45Z

Command "bench --runtime dev --pallet pallet_assets-precompiles" has failed ❌! See logs here

0xRVE added 2 commits January 21, 2026 09:55

added evm-compat crate in pallet-assets

dc1b49d

moved logic into assets/precompiles

01bc26f

0xRVE requested a review from a team as a code owner January 22, 2026 09:46

Revert "added evm-compat crate in pallet-assets"

4881b06

This reverts commit dc1b49d.

0xRVE requested review from acatangiu and bkchr January 22, 2026 09:49

0xRVE added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jan 22, 2026

Update from github-actions[bot] running command 'prdoc --audience run…

e1aed98

…time_dev --bump minor'

0xRVE changed the title ~~[WIP][pallet-assets] ad ForeignAssetIdExtractor to assets precompile~~ [WIP][pallet-assets] add ForeignAssetIdExtractor to assets precompile Jan 22, 2026

Update pr_10869.prdoc

518483d

0xRVE added the T7-smart_contracts This PR/Issue is related to smart contracts. label Jan 22, 2026

0xRVE added 2 commits January 22, 2026 11:06

zepter

6d83853

Merge branch 'rve/8659-assets-precompile' of github.com-work:parityte…

4f0d2da

…ch/polkadot-sdk into rve/8659-assets-precompile

acatangiu reviewed Jan 22, 2026

View reviewed changes

substrate/frame/assets/precompiles/src/foreign_assets.rs Outdated Show resolved Hide resolved

prdoc/pr_10869.prdoc Outdated Show resolved Hide resolved

substrate/frame/assets/precompiles/src/foreign_assets.rs Outdated Show resolved Hide resolved

0xRVE added 5 commits January 22, 2026 13:48

added check to avoid foreign asset hash collision

03c1bd4

update prdoc

1b3ba4f

fix compilation

9623664

clippy

8f9530c

zepter

06b9f65

0xRVE force-pushed the rve/8659-assets-precompile branch from 27ff790 to 06b9f65 Compare January 23, 2026 07:52

0xRVE added 5 commits January 23, 2026 10:37

added tests

99a6617

taplo

bf81f0b

fix ci

3a828f1

fix ci

aeb3994

fix error

c5c92d7

0xRVE requested review from acatangiu and pgherveou January 23, 2026 15:08

added pallet-assets-precompiles to node runtime

4093bf1

Update from github-actions[bot] running command 'bench --runtime dev …

3166112

…--pallet pallet_assets_precompiles'

pgherveou reviewed Jan 30, 2026

View reviewed changes

0xRVE added 6 commits January 30, 2026 14:12

review fixes

a5469d7

fix migration.rs

c9175e7

in migration.rs change can_consume+consume to try_consume

98d5544

removed some code and comments in migration_benchmark.rs

8f59004

in tests.rs review fixes

31b04ed

format

2b7b273

pgherveou reviewed Jan 30, 2026

View reviewed changes

0xRVE added 6 commits January 30, 2026 15:28

removed idempotent

bc74d06

removed redundant pallet::

a4e3390

changed Blake2_128Concat to IDentity

26cad5c

remove unused import

6971006

make migration benchmark pub(crate)

a167412

remove redundant exports

906d510

0xRVE requested a review from pgherveou January 30, 2026 16:28

pgherveou reviewed Jan 30, 2026

View reviewed changes

pgherveou approved these changes Jan 30, 2026

View reviewed changes

added Blake2_128Concat for AssetId(Location) -> u32 map

a4df7bc

	//! ### Design Goals
	//!
	//! 1. Must automatically execute migrations over multiple blocks.
	//! 2. Must expose information about whether migrations are ongoing.
	//! 3. Must respect pessimistic weight bounds of migrations.
	//! 4. Must execute migrations in order. Skipping is not allowed; migrations are run on a
	//! all-or-nothing basis.
	//! 5. Must prevent re-execution of past migrations.
	//! 6. Must provide transactional storage semantics for migrations.
	//! 7. Must guarantee progress.


		const PRECOMPILE_MAPPINGS_MIGRATION_ID: &[u8; 32] = b"foreign-asset-precompile-mapping";

		/// Progressive states of the precompile mappings migration.

		pub use migration::{MigrateForeignAssetPrecompileMappings, MigrationState};
		pub use weights::{SubstrateWeight, WeightInfo as MigrationWeightInfo};

[pallet-assets] add ForeignAssetIdExtractor to assets precompile #10869

Are you sure you want to change the base?

[pallet-assets] add ForeignAssetIdExtractor to assets precompile #10869

Conversation

0xRVE commented Jan 22, 2026

Uh oh!

0xRVE commented Jan 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu commented Jan 22, 2026

Uh oh!

0xRVE commented Jan 23, 2026

Uh oh!

0xRVE commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

0xRVE commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xRVE Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgherveou Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

0xRVE Jan 30, 2026 •

edited

Loading

pgherveou Jan 30, 2026 •

edited

Loading