Skip to content

notifications/tests: Fix flaky libp2p_disconnects_libp2p_substream test #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 1 commit into from
Jan 30, 2026
+14 −3
Merged

notifications/tests: Fix flaky libp2p_disconnects_libp2p_substream test #10886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions substrate/client/network/src/protocol/notifications/tests/conformance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ async fn libp2p_disconnects_libp2p_substream() {

libp2p_rhs.dial(libp2p_lhs_address).unwrap();

// Disarm first timer interval that fires immediately.
let mut timer = tokio::time::interval(std::time::Duration::from_secs(5));
// Timeout as a safety guard in case the test hangs.
let mut timer = tokio::time::interval(std::time::Duration::from_secs(60));
timer.tick().await;

let mut sink = None;
Expand All @@ -388,7 +388,7 @@ async fn libp2p_disconnects_libp2p_substream() {
loop {
tokio::select! {
_ = timer.tick() => {
break;
panic!("Test timed out waiting for expected events");
}

event = libp2p_lhs.select_next_some() => {
Expand Down Expand Up @@ -488,6 +488,17 @@ async fn libp2p_disconnects_libp2p_substream() {

},
}

// Check if all expected events have occurred
if open_times == 2 &&
notification_count == 4 &&
recv_1111 == 2 &&
recv_2222 == 2 &&
recv_3333 == 2 &&
recv_4444 == 2
{
break;
}
}

assert_eq!(open_times, 2);
Expand Down
Loading