fix[frame-system]: force explicit weight configuration in default configs #10901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
requested changes
Jan 26, 2026
|
|
||
| /// Weight information for the extrinsics of this pallet. | ||
| type SystemWeightInfo = (); | ||
| type SystemWeightInfo = crate::MustOverrideWeightInfo; |
Member
There was a problem hiding this comment.
As proposed by @gui1117, we should remove the default values and not add this hack here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10758
Replaced the default () implementations for
SystemWeightInfoandExtensionsWeightInfowithMustOverrideWeightInfoandMustOverrideExtensionsWeightInfotypes that panic at runtime if used. This forces runtime developers to explicitly provide weight configurations.