Skip to content

Conversation

@YichiZhang0613
Copy link
Contributor

Description

For below assertion, it looks like the message is inaccurate. the message always says "deposit mismatch" even when other fields fail (owner, refcount, code_len, etc.). This could be misleading.

assert_eq!(
			migrated,
			new::CodeInfo {
				owner: old_code_info.owner.clone(),
				deposit: old_code_info.deposit,
				refcount: old_code_info.refcount,
				code_len: old_code_info.code_len,
				behaviour_version: old_code_info.behaviour_version,
				code_type: BytecodeType::Pvm,
			},
			"Migration failed: deposit mismatch for key {code_hash:?}",
		);

@bkchr bkchr requested a review from pgherveou January 29, 2026 10:11
@bkchr bkchr added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants