[pallet-revive] Aggregate gas_cost for nested calls in execution tracer #10928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExecutionTracerwas reportinggasCost=0for parent traces containing sub-calls. The gasCost should reflect the opcode cost plus the cumulative gas consumed by all sub-calls.This PR:
Review Notes
To check that
ExecuteTracerhasgasCost=0for any*CALLtrace. Run delegatecall-playground.ts*This can also be checked in the benchmark reports, e.g. table.
To check Geth behaviour run the same script with geth node.