Skip to content

[stable2512] Backport #10880 #10929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sigurpol merged 1 commit into from
Jan 28, 2026
Merged

[stable2512] Backport #10880 #10929

sigurpol merged 1 commit into from
Jan 28, 2026

Conversation

@paritytech-release-backport-bot
Copy link

@paritytech-release-backport-bot paritytech-release-backport-bot bot commented Jan 28, 2026

Backport #10880 into stable2512 from cirko33.

See the documentation on how to use this bot.

@cirko33 @github-actions @mertwole
Remove failing assertion related to VoterList count mismatch (#10880)
f53140a 
Updated bags-list so that on_insert queues items into PendingRebag
instead of failing, and removed the invariant that required VoterList's
count to equal the combined number of Nominators and Validators. This is
safe while bags-list is locked. After unlocking, on_idle drains
PendingRebag, and the counts converge back to consistency over time.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mertwole <[email protected]>
(cherry picked from commit df0500a)
@paritytech-release-backport-bot paritytech-release-backport-bot bot requested a review from a team as a code owner January 28, 2026 17:05
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 28, 2026
@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Jan 28, 2026
Merged
@github-actions github-actions bot requested a review from cirko33 January 28, 2026 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@sigurpol sigurpol merged commit d1b89b4 into stable2512 Jan 28, 2026
260 of 270 checks passed
@sigurpol sigurpol deleted the backport-10880-to-stable2512 branch January 28, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurpol sigurpol sigurpol approved these changes

@cirko33 cirko33 Awaiting requested review from cirko33

Assignees

@cirko33 cirko33

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sigurpol @cirko33