benchmarking: fix DB read/write counts #10947
Open
+913
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #10802 added `reset_read_write_count()` at the end of commit_db() to prevent warmup operations from appearing in benchmarking results. However, commit_db is called twice: one on_before_start() closure before benchmark, and one after benchmark execution after benchmark. This PR moves read_write_count() call before the post-benchmark commit_db() call.
sigurpol
added
T12-benchmarks
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
mertwole
reviewed
Jan 30, 2026
ggwpez
reviewed
Jan 30, 2026
bkchr
reviewed
Jan 30, 2026
Contributor
Author
|
Tested via Pallet: "pallet_staking_async", Extrinsic: "force_apply_min_commission", Lowest values: [], Highest values: [], Steps: 2, Repeat: 1
Raw Storage Info
========
Storage: `Staking::MinCommission` (r:1 w:0)
Proof: `Staking::MinCommission` (`max_values`: Some(1), `max_size`: Some(4), added: 499, mode: `MaxEncodedLen`)
Storage: `Staking::Validators` (r:1 w:1)
Proof: `Staking::Validators` (`max_values`: None, `max_size`: Some(45), added: 2520, mode: `MaxEncodedLen`)
Median Slopes Analysis
========
-- Extrinsic Time --
Model:
Time ~= 58.33
µs
Reads = 2
Writes = 1
Recorded proof Size = 640
Min Squares Analysis
========
-- Extrinsic Time --
Model:
Time ~= 58.33
µs
Reads = 2
Writes = 1
Recorded proof Size = 640 |
Contributor
Author
Fair - I was not sure if doing it in a follow-up PR or here, but seems reasonable to do it here. Lemme |
Contributor
Author
|
/cmd bench --pallet pallet_staking_async --runtime asset-hub-westend |
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has started 🚀 See logs here |
Member
|
/cmd bench --pallet pallet_conviction_voting --runtime asset-hub-westend |
Contributor
|
Command "bench --pallet pallet_conviction_voting --runtime asset-hub-westend" has started 🚀 See logs here |
Contributor
Author
let me add that to the prdoc too 😄 |
kianenigma
approved these changes
Jan 30, 2026
bkchr
approved these changes
Jan 30, 2026
…t_staking_async --runtime asset-hub-westend'
Contributor
|
Command "bench --pallet pallet_staking_async --runtime asset-hub-westend" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
…t_conviction_voting --runtime asset-hub-westend'
Contributor
|
Command "bench --pallet pallet_conviction_voting --runtime asset-hub-westend" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10802 added
reset_read_write_count()at the end of commit_db() to prevent warmup operations from appearing in benchmarking results. However, commit_db is called twice: one onon_before_start()closure before benchmark, and one after benchmark execution after benchmark.This PR whitelists the warmup key used in commit_db so that it doesn't appear in the read/write count.
We also regenerated staking-async weights (wrongly benchmarked in #10802) and conviction-voting to check both v1 and v2 benchmarking.