collator-protocol revamp: Send RC PeerId with ApprovedPeer UMP signal#12388
Merged
Conversation
tdimitrov
changed the title
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
tdimitrov
added
T9-cumulus
…e_dev --bump patch'
alindima
approved these changes
Jun 23, 2026
serban300
approved these changes
Jun 30, 2026
sandreim
approved these changes
Jul 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-12388-to-stable2603
git worktree add --checkout .worktree/backport-12388-to-stable2603 backport-12388-to-stable2603
cd .worktree/backport-12388-to-stable2603
git reset --hard HEAD^
git cherry-pick -x 44b3a384d3ac58acd5e4dac23a661532ba380ad7 |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
tdimitrov
added a commit
that referenced
this pull request
Jul 7, 2026
…#12388) Currently the collator sends its parachain PeerId within the ApprovedPeer UMP signal, which is wrong because this peer id is not known on the relay chain. As a result on CandidateIncluded event the score is bumped for the wrong PeerId and the collator remains with zero reputation no matter its honest work. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 44b3a38)
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jul 7, 2026
Backport #12388 into `stable2606` from tdimitrov. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jul 10, 2026
Backport #12388 into `stable2603` from tdimitrov. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the collator sends its parachain PeerId within the ApprovedPeer UMP signal, which is wrong because this peer id is not known on the relay chain.
As a result on CandidateIncluded event the score is bumped for the wrong PeerId and the collator remains with zero reputation no matter its honest work.