Skip to content

Remove deprecated build-spec CLI subcommand#12586

Open
Kanasjnr wants to merge 10 commits into
paritytech:masterfrom
Kanasjnr:kanas/remove-build-spec
Open

Remove deprecated build-spec CLI subcommand#12586
Kanasjnr wants to merge 10 commits into
paritytech:masterfrom
Kanasjnr:kanas/remove-build-spec

Conversation

@Kanasjnr

@Kanasjnr Kanasjnr commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Remove the deprecated build-spec CLI subcommand and BuildSpecCmd from sc-cli.
  • Migrate all callers (nodes, templates, scripts, docs, zombienet) to export-chain-spec.

Part of #11561

@Kanasjnr
Remove deprecated build-spec CLI subcommand.
77f431b 
Migrate callers to export-chain-spec and drop BuildSpecCmd from sc-cli.
@Kanasjnr Kanasjnr requested review from a team as code owners July 7, 2026 14:38
@Kanasjnr

Kanasjnr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience node_dev --bump major

@Kanasjnr

Kanasjnr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/cmd label T13-deprecation

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk Bot added the T13-deprecation The current issue/pr is, or should be, part of a deprecation process. label Jul 7, 2026
@franciscoaguirre

franciscoaguirre commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@Kanasjnr Check out the CI jobs, they are failing because you removed build-spec. Make sure all references to it are removed.

@Kanasjnr

Kanasjnr commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Kanasjnr Check out the CI jobs, they are failing because you removed build-spec. Make sure all references to it are removed.

I was waiting on @bkontur i reached out regarding it the CI is failing on zombienet tests because zombienet-orchestrator 0.4.9 still defaults to build-spec for chain spec generation. After removing the subcommand, tests like sync_blocks_from_tip_without_connected_collator and minimal_template_block_production_test fail with unrecognized subcommand 'build-spec'.

Options I was thinking was
Maybe to Defer this PR until zombienet-orchestrator switches its default to export-chain-spec or Override with_chain_spec_command across ~70 zombienet test files in this PR (mechanical, same pattern as block_building.rs)

franciscoaguirre
franciscoaguirre approved these changes Jul 9, 2026
View reviewed changes
Comment thread cumulus/test/service/src/cli.rs Outdated
Comment thread prdoc/pr_12586.prdoc Outdated
Comment thread templates/minimal/node/src/cli.rs Outdated
Comment thread templates/solochain/node/src/cli.rs Outdated
bkontur and others added 2 commits July 10, 2026 11:58
@bkontur @franciscoaguirre
Apply suggestions from code review
c060559 
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
@bkontur
Merge branch 'master' into kanas/remove-build-spec
571093c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes
@xermicus xermicus xermicus approved these changes

Assignees

No one assigned

Labels

T13-deprecation The current issue/pr is, or should be, part of a deprecation process.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kanasjnr @franciscoaguirre @xermicus @bkontur