Skip to content

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Sep 4, 2023

Continuation of paritytech/substrate#14805

  • Adds Simple Analytics script injection to .gitlab/pipeline/build.yml rust doc build step
  • Fixes cargo doc features
  • Updates .maintain/rustdocs-release.sh to clarify it is no longer used anywhere

Question

.maintain/rustdocs-release.sh is no longer used anywhere.

I updated the documentation to indicate this to prevent future confusion, but unsure if we should just remove it completely?

@paritytech-ci paritytech-ci requested review from a team September 4, 2023 04:38
@liamaharon liamaharon changed the title [testing ci / DNM] rust docs: add simple analytics rust docs: add simple analytics Sep 4, 2023
@liamaharon liamaharon added the T11-documentation This PR/Issue is related to documentation. label Sep 4, 2023
@paritytech-ci paritytech-ci requested a review from a team September 4, 2023 06:31
# Inject Simple Analytics (https://www.simpleanalytics.com/) privacy preserving tracker into
# all .html files
- |
inject_simple_analytics() {
Copy link
Member

@ggwpez ggwpez Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see a CI scripts folder anymore, we used to have one 🤔
Do yo uknow where it is @alvicsam?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a little bit messy so I decided to put files and scripts related to gitlab to .gitlab folder and the same for github actions.

@liamaharon
Copy link
Contributor Author

bot merge

@command-bot
Copy link

command-bot bot commented Sep 5, 2023

@liamaharon Unknown command "merge". Refer to help docs and/or source code.

@liamaharon liamaharon merged commit 7217a5d into master Sep 5, 2023
@liamaharon liamaharon deleted the liam-rust-doc-simple-analytics branch September 5, 2023 02:31
ordian added a commit that referenced this pull request Sep 6, 2023
* master: (24 commits)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  rust docs: add simple analytics (#1377)
  Contracts: Update read_sandbox (#1390)
  Extract block announce validation from `ChainSync` (#1170)
  [ci] Remove runtime-benchmarks from tests (#1335)
  ...
Ank4n pushed a commit that referenced this pull request Sep 8, 2023
* inject simple analytics

* comments

* fix chown

* comments

* doc features
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
* inject simple analytics

* comments

* fix chown

* comments

* doc features
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
* inject simple analytics

* comments

* fix chown

* comments

* doc features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T11-documentation This PR/Issue is related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants