bags-list: implement pending rebag #9725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PendingRebag storage to queue accounts that fail insertion during lock. - Modify on_idle to process pending accounts with priority before regular accounts. - Add cleanup logic for non-staking pending accounts.
sigurpol
added
T2-pallets
|
/cmd prdoc --audience runtime_dev --bump patch |
sigurpol
requested review from
Ank4n,
kianenigma,
nkpar and
seadanda
and removed request for
a team and
Ank4n
…time_dev --bump patch'
|
/cmd bench --pallet pallet_bags_list --runtime asset-hub-westend |
|
/cmd bench --pallet pallet_bags_list --runtime dev |
|
Command "bench --pallet pallet_bags_list --runtime asset-hub-westend" has started 🚀 See logs here |
|
Command "bench --pallet pallet_bags_list --runtime dev" has started 🚀 See logs here |
sigurpol
removed
the
A4-backport-unstable2507
…t_bags_list --runtime asset-hub-westend'
|
Command "bench --pallet pallet_bags_list --runtime asset-hub-westend" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
…t_bags_list --runtime dev'
|
Command "bench --pallet pallet_bags_list --runtime dev" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
kianenigma
reviewed
Sep 15, 2025
kianenigma
reviewed
Oct 9, 2025
kianenigma
reviewed
Oct 9, 2025
kianenigma
reviewed
Oct 9, 2025
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
kianenigma
reviewed
Oct 10, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
kianenigma
reviewed
Oct 10, 2025
kianenigma
reviewed
Oct 10, 2025
kianenigma
approved these changes
Oct 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
Fix the issue where registering a nominator or validator while the bags list is locked would completely ignore the account, making it unreachable for on_idle rebagging. Changes: - Add PendingRebag storage to queue accounts that fail insertion during lock. - Modify on_idle to process pending accounts with priority before regular accounts. - Add cleanup logic for non-staking pending accounts. Related issue: paritytech-secops/srlabs_findings#567 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kian Paimani <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-9725-to-stable2509
git worktree add --checkout .worktree/backport-9725-to-stable2509 backport-9725-to-stable2509
cd .worktree/backport-9725-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 5c63e5e3c9b96e4177572b00672942fdbc65433e
git push --force-with-lease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where registering a nominator or validator while the bags list is locked would completely ignore the account, making it unreachable for on_idle rebagging.
Changes:
Related issue: https://github.com/paritytech-secops/srlabs_findings/issues/567