Skip to content

Conversation

DenzelPenzel
Copy link
Contributor

Description

#9877

@DenzelPenzel DenzelPenzel requested review from a team as code owners October 7, 2025 16:57
… zombienet-workflow-call

# Conflicts:
#	.github/workflows/zombienet-reusable-preflight.yml
@pepoviola
Copy link
Contributor

Thanks @DenzelPenzel , looks good but I think this pr contains also the changes in the logs (not merged yet). And we need to make the call to the workflow in the build_images.
Thx!

@DenzelPenzel DenzelPenzel force-pushed the zombienet-workflow-call branch 5 times, most recently from 6a935ec to acc5e0f Compare October 8, 2025 15:33
@DenzelPenzel DenzelPenzel added T10-tests This PR/Issue is related to tests. R0-no-crate-publish-required The change does not require any crates to be re-published. labels Oct 8, 2025
@DenzelPenzel DenzelPenzel force-pushed the zombienet-workflow-call branch 2 times, most recently from 79857a4 to a0e85af Compare October 8, 2025 16:01
@DenzelPenzel DenzelPenzel force-pushed the zombienet-workflow-call branch from a0e85af to 75c8399 Compare October 8, 2025 16:34
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/18351612704
Failed job name: test-linux-stable

Copy link
Contributor

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!!

@alvicsam
Copy link
Contributor

alvicsam commented Oct 9, 2025

It looks that there is a deadlock that prevents zombienet tests from starting: https://github.com/paritytech/polkadot-sdk/actions/runs/18356902291

Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-cumulus'
Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-polkadot'
Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-substrate'
Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-parachain-template'

@pepoviola
Copy link
Contributor

It looks that there is a deadlock that prevents zombienet tests from starting: https://github.com/paritytech/polkadot-sdk/actions/runs/18356902291

Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-cumulus'
Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-polkadot'
Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-substrate'
Canceling since a deadlock was detected for concurrency group: 'Build and push images-9960' between a top level workflow and 'trigger-zombienet-parachain-template'

hmm, thanks @alvicsam. I will check this erros.

@pepoviola
Copy link
Contributor

@alvicsam concurrency issue is now fixed, but all the test are show in the build workflow which is not good for discovery.
Maybe we can add only one workflow that make the wait logic and trigger the rest of the workflows, so that way I think we will be covered in terms of api request. wdyt?

image

@alvicsam
Copy link
Contributor

alvicsam commented Oct 9, 2025

I don't see the problem of discoverability. All zombienet jobs are in the same list of jobs in the github UI but the name is slightly different. We can change the workflow name if you want. I would prefer not adding a wait workflow because it is error-prone and consumes API requests and we can easily avoid both issues with on: workflow_call.

off-topic: there is one job that often exceeds timeout

@pepoviola
Copy link
Contributor

Yes, that test is disabled as part of this pr https://github.com/paritytech/polkadot-sdk/pull/9957/files#r2416989294.
Oks, let me think a better name but for now we can merge as is.

Thx!

@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 9, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T10-tests This PR/Issue is related to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants