Skip to content

pallet-xcm: extract precompiles to a separate crate #9985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 13, 2025
Merged

pallet-xcm: extract precompiles to a separate crate #9985

merged 18 commits into from
Oct 13, 2025
+1,381 −919

Conversation

tiagobndr
Copy link
Contributor

@tiagobndr tiagobndr commented Oct 9, 2025 •
edited
Loading

This PR extracts the XCM precompile from pallet-xcm into a new standalone crate pallet-xcm-precompiles to resolve an unwanted dependency issue. Previously, the XCM precompile was implemented directly in pallet-xcm/src/precompiles.rs, which required pallet-xcm to depend on pallet-revive, introducing it as a transitive dependency for all parachains using pallet-xcm.

Closes #9955

@tiagobndr tiagobndr self-assigned this Oct 9, 2025
@tiagobndr tiagobndr added T6-XCM This PR/Issue is related to XCM. T7-smart_contracts This PR/Issue is related to smart contracts. labels Oct 9, 2025
@tiagobndr tiagobndr marked this pull request as ready for review October 9, 2025 16:27
@tiagobndr tiagobndr requested a review from a team as a code owner October 9, 2025 16:27
@tiagobndr
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@paritytech paritytech deleted a comment from github-actions bot Oct 9, 2025
@paritytech paritytech deleted a comment from github-actions bot Oct 9, 2025
@paritytech paritytech deleted a comment from github-actions bot Oct 9, 2025
@tiagobndr tiagobndr marked this pull request as draft October 9, 2025 19:24
@tiagobndr tiagobndr marked this pull request as ready for review October 10, 2025 12:27
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/18407442912
Failed job name: test-linux-stable-runtime-benchmarks

franciscoaguirre
franciscoaguirre approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@franciscoaguirre franciscoaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@bkchr bkchr enabled auto-merge October 11, 2025 22:02
@bkchr
Copy link
Member

bkchr commented Oct 12, 2025

@tiagobndr please fix the check licenses job.

@bkchr bkchr added this pull request to the merge queue Oct 13, 2025
Merged via the queue into master with commit 2e716e1 Oct 13, 2025
255 of 276 checks passed
@bkchr bkchr deleted the tb/xcm-gate-precompiles branch October 13, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@bkchr bkchr bkchr approved these changes

Assignees

@tiagobndr tiagobndr

Labels

T6-XCM This PR/Issue is related to XCM. T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pallet-xcm: extract precompiles to a separate crate

3 participants

@tiagobndr @bkchr @franciscoaguirre