[WIP] enabled half of test call_invalid_opcode #9989
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
|
As far as I can see it the behavior on resolc is wrong. So why would we write a test that enforces the wrong behavior? What we should do is to change the test to enforce the correct behavior and only enable it on complying backend. So we should actually do the inverse here. Enabling it on solc. Or am I wrong? |
Agreed. |
0xRVE
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the PVM backend part of this test
call_invalid_opcodeinpolkadot-sdk/substrate/frame/revive/src/tests/sol/contract.rs