Skip to content

Upgrade polkadot stable2503 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Apr 9, 2025
Merged

Upgrade polkadot stable2503 #295

merged 37 commits into from
Apr 9, 2025

Conversation

Moliholy
Copy link
Collaborator

@Moliholy Moliholy commented Apr 8, 2025

Summary

alexggh and others added 30 commits March 20, 2025 15:24
@alexggh
Hitting deadline
3510baf 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Squeze even more transactions into the block
5164f7c 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Add optimization from polkadot-sdk
06bd8e6 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Regenerated weights
f4cacc1 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Update lib.rs
66d38d1
@alexggh
Update lib.rs
ad83219
@alexggh
Revert "Regenerated weights"
6518487 
This reverts commit f4cacc1.
@alexggh
Merge remote-tracking branch 'origin/main' into alexggh/main2
d103b71
@alexggh
remove production profile
f9d1499 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Adjust per read/write costs
ac2b12a 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh
Add a few more comments
e4a7cc4 
Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh @RomarQ
Update runtime/common/src/lib.rs
fd1f099 
Co-authored-by: Rodrigo Quelhas <[email protected]>
@Moliholy
Upgrade to polkadot-stable2503-rc1
17190a5
@Moliholy
Add max pov percentage to node
6c3985b
@Moliholy
Merge remote-tracking branch 'origin/alexggh/main' into upgrade-polka…
2dd10e5 
…dot-stable2503
@Moliholy
Increase mainnet spec version
6bf1d95
@Moliholy
Add WeightReclaim pallet to benchmarks
d73bd53
@Moliholy
Add the bounties pallet
679a25f
@Moliholy
Add the identity pallet
bb72188
@Moliholy
Increase binary versions
d5271b6
@Moliholy
Do not use text output in zombienet
abd347a
@Moliholy
Improve zombienet script
5d99ce6
@Moliholy
Link Treasury and Bounties
0f02ed4
@Moliholy
Fix bounties benchmarks
f5a2d25
@Moliholy
Fix identity authority origin
1275828
@Moliholy
Upgrade to polkadot-stable2503-rc2
9021b36
@Moliholy
Add weights for testnet
952afdf
@Moliholy
Upgrade to polkadot-stable2503
97639ad
@Moliholy
Use the v1.3.0 version of pallet-collator-staking
85f3064
@Moliholy
Add mainnet weights
0c18b98
@Moliholy Moliholy self-assigned this Apr 8, 2025
@Moliholy Moliholy force-pushed the upgrade-polkadot-stable2503 branch from 3dd3032 to 3ed3369 Compare April 9, 2025 09:31
sandreim
sandreim reviewed Apr 9, 2025
View reviewed changes
Copy link

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that RocksDB weights not changed for main net:

pub const RocksDbWeight: RuntimeDbWeight = RuntimeDbWeight {
	read: 20_000 * constants::WEIGHT_REF_TIME_PER_NANOS,
	write: 37_000 * constants::WEIGHT_REF_TIME_PER_NANOS,
};

@Moliholy
Copy link
Collaborator Author

Moliholy commented Apr 9, 2025

LGTM except that RocksDB weights not changed for main net:

@sandreim done in c58ca1a.

This was referenced Apr 9, 2025
Closed
Closed
alexggh
alexggh approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@alexggh alexggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Thank you!

runtime/mainnet/src/weights/cumulus_pallet_parachain_system.rs
@@ -1,8 +1,8 @@

//! Autogenerated weights for `cumulus_pallet_parachain_system`
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 46.0.0
//! DATE: 2025-03-28, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUBSTRATE BENCHMARK CLI VERSION 32.0.0 seems older than the previous one, any idea why ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no. I just run the exact same command as we usually do. The benchmarking engine is integrated in the client.

valentinfernandez1
valentinfernandez1 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@valentinfernandez1 valentinfernandez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work 🚀

@Moliholy Moliholy merged commit 0914995 into main Apr 9, 2025
4 checks passed
@Moliholy Moliholy deleted the upgrade-polkadot-stable2503 branch April 9, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinfernandez1 valentinfernandez1 valentinfernandez1 approved these changes

@alexggh alexggh alexggh approved these changes

@sandreim sandreim sandreim approved these changes

@metricaez metricaez Awaiting requested review from metricaez

Assignees

@Moliholy Moliholy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moliholy @valentinfernandez1 @alexggh @sandreim