Upgrade polkadot stable2503 #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
This reverts commit f4cacc1.
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Co-authored-by: Rodrigo Quelhas <[email protected]>
moliholy
requested review from
alexggh,
metricaez,
sandreim and
valentinfernandez1
moliholy
force-pushed
the
upgrade-polkadot-stable2503
branch
from
3dd3032 to
3ed3369
Compare
sandreim
reviewed
Apr 9, 2025
sandreim
left a comment
sandreim
left a comment
There was a problem hiding this comment.
LGTM except that RocksDB weights not changed for main net:
pub const RocksDbWeight: RuntimeDbWeight = RuntimeDbWeight {
read: 20_000 * constants::WEIGHT_REF_TIME_PER_NANOS,
write: 37_000 * constants::WEIGHT_REF_TIME_PER_NANOS,
};
Contributor
Author
This was referenced Apr 9, 2025
alexggh
approved these changes
Apr 9, 2025
Contributor
alexggh
left a comment
alexggh
left a comment
There was a problem hiding this comment.
Looks good to me as well. Thank you!
| //! | ||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 46.0.0 | ||
| //! DATE: 2025-03-28, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]` | ||
| //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0 |
Contributor
There was a problem hiding this comment.
SUBSTRATE BENCHMARK CLI VERSION 32.0.0 seems older than the previous one, any idea why ?
Contributor
Author
There was a problem hiding this comment.
Actually no. I just run the exact same command as we usually do. The benchmarking engine is integrated in the client.
sandreim
approved these changes
Apr 9, 2025
valentinfernandez1
approved these changes
Apr 9, 2025
Collaborator
valentinfernandez1
left a comment
valentinfernandez1
left a comment
There was a problem hiding this comment.
LGTM great work 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
polkadot-stable2503.