Added basic CI workflow #13
Conversation
xermicus
left a comment
xermicus
left a comment
There was a problem hiding this comment.
Looking good! Can you please also add cargo machete? I like how it helps vetting the workspace.
.github/workflows/test.yml
Outdated
|
|
||
| - name: Test CLI | ||
| run: make test-cli |
There was a problem hiding this comment.
| - name: Test CLI | |
| run: make test-cli |
There is no test-cli target in the Makefile
There was a problem hiding this comment.
Yes, I have remove it on an old revision and forgot to clean it from the yml file also. I will do it in the next revision.
Makefile
Outdated
| clippy: | ||
| cargo clippy --all-features --workspace -- --deny warnings | ||
|
|
||
| test-workspace: |
There was a problem hiding this comment.
Nit: Since there is only one could be shortened to just make test.
Makefile
Outdated
| @@ -0,0 +1,10 @@ | |||
| .PHONY: format clippy test-workspace test-cli | |||
There was a problem hiding this comment.
| .PHONY: format clippy test-workspace test-cli | |
| .PHONY: format clippy test-workspace |
There was a problem hiding this comment.
Yes, I have remove it on an old revision and forgot to clean it from the yml file also. I will do it in the next revision.
crates/core/Cargo.toml
Outdated
| serde_json = { workspace = true } | ||
| temp-dir = { workspace = true } | ||
|
|
||
| [package.metadata.cargo-machete] |
There was a problem hiding this comment.
Instead of allowing exceptions please just remove them from the dependencies above. Unless they are actually false positives which I doubt :)
There was a problem hiding this comment.
I was thinking the other way around. Since the project is at the initial phase and there are a lot of things to develop, I didn't want to remove some "unused" dependencies and add them back in the next iteration
There was a problem hiding this comment.
I see where you are coming from. But please remove them and remove the exception unless its a false positve. It's the sane for everything else too: We have cargo fmt pass, cargo clippy pass, cargo test pass without any unnecessary exceptions too, so why not start with a passing machete. It's not big deal to add and remove dependencies on the go.
No description provided.