Extended execute_input method #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
approved these changes
Jun 10, 2025
crates/core/src/driver/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn print_diff_mode(label: &str, diff: &DiffMode) { |
Member
There was a problem hiding this comment.
Those should emit trace logs instead of println! to the console.
Contributor
Author
There was a problem hiding this comment.
Changed in the new revision
crates/core/src/driver/mod.rs
Outdated
| if leader_diff == follower_diff { | ||
| log::info!("State diffs match between leader and follower."); | ||
| } else { | ||
| log::warn!("State diffs mismatch between leader and follower."); |
Member
There was a problem hiding this comment.
Suggested change
| log::warn!("State diffs mismatch between leader and follower."); | |
| log::debug!("State diffs mismatch between leader and follower."); |
This is expected and not indicating a problem per se.
crates/core/src/driver/mod.rs
Outdated
| follower_state.execute_input(input, self.follower_node)?; | ||
|
|
||
| if leader_diff == follower_diff { | ||
| log::info!("State diffs match between leader and follower."); |
Member
There was a problem hiding this comment.
Suggested change
| log::info!("State diffs match between leader and follower."); | |
| log::debug!("State diffs match between leader and follower."); |
Contributor
Author
There was a problem hiding this comment.
Changed in the new revision
crates/core/src/driver/mod.rs
Outdated
| //node.trace_transaction(receipt) | ||
| todo!() | ||
|
|
||
| log::debug!("Transaction receipt: {:?}", receipt); |
Member
There was a problem hiding this comment.
Suggested change
| log::debug!("Transaction receipt: {:?}", receipt); | |
| log::trace!("Transaction receipt: {:?}", receipt); |
Contributor
Author
There was a problem hiding this comment.
Changed in the new revision
crates/core/src/driver/mod.rs
Outdated
|
|
||
| let trace = node.trace_transaction(receipt.clone())?; | ||
|
|
||
| log::debug!("Trace result: {:?}", trace); |
Member
There was a problem hiding this comment.
Suggested change
| log::debug!("Trace result: {:?}", trace); | |
| log::trace!("Trace result: {:?}", trace); |
Contributor
Author
There was a problem hiding this comment.
Changed in the new revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the execute method for the Nodes, in order to be able to extract the DiffMode and the TransactionTrace.
This pr is part of this: #7