feat: coretime implementation #1558
Conversation
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
744895d to
6de3395
Compare
filvecchiato
changed the title
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
4efc743 to
f6e8a77
Compare
filvecchiato
changed the title
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
9ef9d68 to
e8a0808
Compare
filvecchiato
force-pushed
the
filippo_coretime_implementation
branch
from
142039d to
4dcdf17
Compare
TarikGul
left a comment
TarikGul
left a comment
There was a problem hiding this comment.
Overall amazing PR! I have a few nits:
-
The typecasting can be removed. AFAIU the types are correctly passed down from PJS so you should be good.
-
For any imported types we can use
import type.
Other than that the PR looks really great!
I removed most of typecasting (nice catch, not sure I was having issues before), I had to leave typecasting for coreDescriptors and paraLifecycles though, we can doublecheck if there is something wrong on my end though
thanks for checking it out! |
Imod7
left a comment
Imod7
left a comment
There was a problem hiding this comment.
Some minor comments and a question. Looks great! 🎉
Nice catches, thanks! On it |
Imod7
left a comment
Imod7
left a comment
There was a problem hiding this comment.
Thanks for updating! All Good! ✅
New Feature: Implements the coretime endpoints for relay chain and for coretime chain.
It includes basic endpoints for single information record recovery, and more advanced endpoints with precomputed calculations and information.