feat: inject controllers using metadata's definition of pallets #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filvecchiato
changed the title
IkerAlus
reviewed
Feb 14, 2025
Member
|
Question: Don't we no longer need the chains-config |
Contributor
Author
It depends if the user decides to inject the controllers or use configurations using the SAS_EXPRESS_CONTROLLERS_CONFIG flag. I'm also using it for the tests but happy to move it outside/on a separate config file |
Imod7
reviewed
Feb 19, 2025
Imod7
reviewed
Feb 21, 2025
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
filvecchiato
force-pushed
the
filippo_dynamic_controllers
branch
from
9326d44 to
afa027c
Compare
Imod7
approved these changes
Mar 2, 2025
Contributor
Imod7
left a comment
Imod7
left a comment
There was a problem hiding this comment.
Looks great! 💯 This is such a great feature so kudos for the initiative and the excellent suggestion. Also, the implementation was super fast!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a new method to inject the required/available controllers for a chain in express by using the pallets defined in the metadata of such chain. It also allows to add a config file in chains_config and then use that by setting SAS_EXPRESS_CONTROLLERS_CONFIG to true.
Each controller now requires two new static variables: controllerName and requiredPallets
ControllerName is the name of the controller to be used in the configs and requiredPallets are the pallets required in the metadata to have the controller injected in the server.