feat: add /transaction/metadata-blob endpoint
#1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
reviewed
Jan 30, 2026
| // Dynamic import helper that TypeScript won't transform to require() | ||
| // This is necessary because @polkadot-api/merkleize-metadata is an ESM-only package | ||
| // eslint-disable-next-line @typescript-eslint/no-implied-eval | ||
| const dynamicImport = new Function('specifier', 'return import(specifier)') as <T>(specifier: string) => Promise<T>; |
Member
There was a problem hiding this comment.
Interesting work around. In order to not mess with the bundler, I am okay with this.
Contributor
Author
There was a problem hiding this comment.
Yeah, it's taken from here with a few mods https://stackoverflow.com/questions/65265420/how-to-prevent-typescript-from-transpiling-dynamic-imports-into-require
TarikGul
reviewed
Jan 30, 2026
TarikGul
reviewed
Jan 30, 2026
src/controllers/transaction/TransactionMetadataBlobController.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an endpoint that returns the metadata blob for offline signers. It uses
@polkadot-ap/merkleize-metadatato generate the blob and proof for a tx.The dynamic imports changes were necessary since the latest versions of
@polkadot-ap/merkleize-metadatause@scure/base@^2.0.0, which is ESM-only.Pending:
Closes #1783