Add support for custom parachains#110
Open
lexnv wants to merge 4 commits into
Open
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
pepoviola
reviewed
Mar 4, 2026
Comment on lines
+522
to
+527
| if let Ok(port) = env::var("ZOMBIE_BITE_AH_PORT") { | ||
| let rpc_port = port.parse().expect("env var ZOMBIE_BITE_AH_PORT must be a valid u16"); | ||
| col_builder.with_rpc_port(rpc_port) | ||
| } else { | ||
| col_builder | ||
| } |
Collaborator
There was a problem hiding this comment.
This was added for the AHM project, but is not needed anymore and is the env var is set will cause issues since we will use the same port for all collators. Can you remove it directly?
pepoviola
reviewed
Mar 4, 2026
| // For custom paras, copy the user's chain spec and clear bootNodes | ||
| // instead of running `doppelganger-parachain build-spec` which may not | ||
| // understand arbitrary runtimes. | ||
| let spec_content = std::fs::read_to_string(&sync_chain) |
Collaborator
There was a problem hiding this comment.
Suggested change
| let spec_content = std::fs::read_to_string(&sync_chain) | |
| let spec_content = tokio::fs::read_to_string(&sync_chain).await.unwrap(); |
Let use tokio::fs here as we use in the rest of the fn.
pepoviola
reviewed
Mar 4, 2026
pepoviola
left a comment
pepoviola
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!! a couple of comments inline :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for custom parachains. Users can:
Testing Done
cc @pepoviola @sandreim