refactor: Bump @aws-sdk/lib-storage and @aws-sdk/client-s3 to 3.1091.0 - #580
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe S3 adapter upgrades ChangesAWS SDK dependency refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 2 2
Lines 225 225
=======================================
Hits 220 220
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closes #573
This co-bumps
@aws-sdk/client-s3alongside@aws-sdk/lib-storage(both from 3.1032.0 to 3.1091.0).Bumping
@aws-sdk/lib-storagealone (as in #573) breaksnpm ci: lib-storage 3.109x declares a peer dependency on@aws-sdk/client-s3^3.109x, which is not satisfied while client-s3 is pinned at 3.1032.0. Bumping both to the same version satisfies the peer requirement and restores a clean install.Verified locally:
npm ciexits 0 with the updated lockfile (no ERESOLVE, no--legacy-peer-deps).Summary by CodeRabbit