Claude/expand felicity card b7dl4#118
Merged
Merged
Conversation
Two fixes: 1. Algorithm (ems.py): When PV surplus alone would fill the battery to 90%+ capacity, stop pruning negative-price charge slots during SOC validation. The overflow is PV-caused — pruning negative-price slots won't prevent it, and charging at negative prices is pure profit. Previously, these slots were pruned alongside non-negative ones, causing the algorithm to miss profitable charging opportunities. 2. Chart (ha_felicity_ems.js): Add 5% padding below the y-axis minimum so bars at the lowest price have visible height. Previously, charge bars at the minimum price were clipped to 0px height — invisible even though the slot was correctly scheduled. Tests updated from 132 to 134: added test_negative_charge_preserved and test_negative_charge_still_pruned_when_pv_insufficient. Three existing tests updated to match new policy (negative slots kept, not pruned). https://claude.ai/code/session_01P9LAQ5ET6SU9dLWULxv2uF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.