Skip to content

PAR-14333: Show memo when present, and not otherwise #19

Open
no-longer-human wants to merge 10 commits intomainfrom
par-14333-memo
Open

PAR-14333: Show memo when present, and not otherwise #19
no-longer-human wants to merge 10 commits intomainfrom
par-14333-memo

Conversation

@no-longer-human
Copy link
Copy Markdown
Collaborator

@no-longer-human no-longer-human commented Jun 6, 2024

This pull request aims to resolve the PAR-14333 issue. The issue involves a missing memo field in the UI on MPC Token transfer transactions for Ledger Nano S/S+/X, but was present for Ledger Stax devices.

  • Ensure that Ledger Nano S/S+/X shows the memo field for transfers with memos.
  • Ensure that all devices hides the field for transfers without memos.
  • This is verified with a new UI test that signs two different transactions right after each other.
  • Additionally: MPC transfer example transactions have been made more distinct, to ensure that tests generate more distinct reference outputs.
  • Additionally: Some code-quality related cleanup have been done for the UI tests.
  • Version has been bumped to 1.0.1

@no-longer-human no-longer-human marked this pull request as ready for review June 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants