Drop environments from ExtendedTunnel#1368
Merged
Merged
Conversation
Update Core to handle them in Tunnel. Do not replicate dataCount and lastErrorCode because they are now per-profile and directly available via environments. Just notify with objectWillChange.send() when there are changes in Tunnel so that the observing views can re-read the values from the updated environments. Pinned profile in macOS no longer makes sense with multiple profiles, and so lastProfileId, which is not necessary in iOS/tvOS where the NE profile keeps .isEnabled even when inactive.
keeshux
added
enhancement
Implied by observing ExtendedTunnel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Core to handle them in Tunnel.
Do not replicate dataCount and lastErrorCode because they are now
per-profile and directly available via environments. Just notify
with objectWillChange.send() when there are changes in Tunnel so
that the observing views can re-read the values from the updated
environments.
Pinned profile in macOS no longer makes sense with multiple
profiles, and so lastProfileId, which is not necessary in iOS/tvOS
where the NE profile keeps .isEnabled even when inactive.
Some UI assumes a single active tunnel, rework it later for #218.
Fixes #1360
Fixes #1367