Improve app and tunnel initialization#1376
Merged
Merged
Conversation
keeshux
added
regression
First, refactor Partout to use PartoutLogger[Context]. Simplify the lifecycle of bootstrap entities. Basically, move the initialization of the app to AppDelegate, and the tunnel's to PacketTunnelProvider. PartoutLogger is created the earliest. To do this: - Make AppContext (production) non-static with a convenience init() - Move TunnelContext code to PacketTunnelProvider, only used there - Move CommonLibrary/UILibrary classes logic to AppDelegate
keeshux
force-pushed
the
bugfix/context-leftovers
branch
from
fa559cc to
f508bcd
Compare
keeshux
changed the title
keeshux
added a commit
that referenced
this pull request
May 20, 2025
Currently false, must default to true. Also, add missing fallback logic to shortcut methods of KeyValueManager. Regression in #1376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, refactor Partout to use PartoutLogger[Context]. Then, simplify the lifecycle of bootstrap entities in a predictable way. Basically, move the initialization of the app to AppDelegate, and the tunnel initialization to PacketTunnelProvider. PartoutLogger is configured the earliest.
To do this:
These fixes must keep the current .appex functionality, so restore the "Logs private data" preference.
For .sysex (Developer ID), #1373, #1374, and #1375 need to be fixed as well.