ABI: Move tunnel hooks to native app#1820
Merged
Merged
Conversation
keeshux
added
refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a native tunnel object to the Swift ABI is trivial in Swift, but it gets convoluted with non-Swift languages because of all the C/JNI machinery.
Instead:
This demands trivial duplication of the native tunnel logic, as it must react to profile events at the app layer. However, this is infinitely easier than adding fragile C/JNI bindings to let Swift control the tunnel directly with Kotlin/JNI or C++.