Skip to content

feat(parser): default required fields #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

eduhdev12
Copy link

New CLI Flag to set all the fields from a struct by default to true

@qequ
Copy link
Collaborator

qequ commented Apr 9, 2025

Hi, thanks for the PR. can you add some tests and update the documentation with what the flag does ?

@eduhdev12
Copy link
Author

Hi, thanks for the PR. can you add some tests and update the documentation with what the flag does ?

Done! Let me know if I missed anything

@qequ
Copy link
Collaborator

qequ commented Apr 24, 2025

@eduhdev12 failed tests please fix the tests

@eduhdev12
Copy link
Author

@eduhdev12 failed tests please fix the tests

I hope now it's passing it :)

@parvez3019
Copy link
Owner

Hi

Test_GenerateExpectedSpecWithDefaultRequired is failing.

=== RUN   Test_GenerateExpectedSpecWithDefaultRequired
time="2025-04-26T10:15:16Z" level=info msg="Parsing Initialized"
time="2025-04-26T10:15:16Z" level=info msg="Parsing Info ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing Modules ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing GoMod Info ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing APIs ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing Completed ..."
time="2025-04-26T10:15:16Z" level=info msg="Writing to open api object file ..."
    app_test.go:[49](https://github.com/parvez3019/go-swagger3/actions/runs/14667147170/job/41202045726?pr=60#step:4:50): 
        	Error Trace:	app_test.go:49
        	Error:      	Not equal: 
        	            	expected: 0
        	            	actual  : 2
        	Test:       	Test_GenerateExpectedSpecWithDefaultRequired
--- FAIL: Test_GenerateExpectedSpecWithDefaultRequired (0.00s)

@eduhdev12
Copy link
Author

Hi

Test_GenerateExpectedSpecWithDefaultRequired is failing.

=== RUN   Test_GenerateExpectedSpecWithDefaultRequired
time="2025-04-26T10:15:16Z" level=info msg="Parsing Initialized"
time="2025-04-26T10:15:16Z" level=info msg="Parsing Info ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing Modules ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing GoMod Info ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing APIs ..."
time="2025-04-26T10:15:16Z" level=info msg="Parsing Completed ..."
time="2025-04-26T10:15:16Z" level=info msg="Writing to open api object file ..."
    app_test.go:[49](https://github.com/parvez3019/go-swagger3/actions/runs/14667147170/job/41202045726?pr=60#step:4:50): 
        	Error Trace:	app_test.go:49
        	Error:      	Not equal: 
        	            	expected: 0
        	            	actual  : 2
        	Test:       	Test_GenerateExpectedSpecWithDefaultRequired
--- FAIL: Test_GenerateExpectedSpecWithDefaultRequired (0.00s)

I don't know why, because on local it's passing without any error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants