Windows support added while maintaining MacOS/Linux compatibility #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I want to merge this but it's a big PR that will require a lot of testing on multiple platforms. If someone can help test this out and write up a testing document with all of the results, I would be happy to merge! Thanks @dan-dean for the awesome work on Windows compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to package.json and inclusion of run-script-os in dev dependencies so that users on MacOS/Linux and users on Windows run different scripts. Added go-compile-windows.sh which builds the binary exe for windows. Modified the README with Windows specific setup steps. I do not have a MacOS or full Linux environment, so you should try my fork on your environment first for compatibility, but hopefully this should do it.