Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSG-4614 #73

Merged
merged 11 commits into from
Aug 30, 2024
Merged

PSG-4614 #73

merged 11 commits into from
Aug 30, 2024

Conversation

SinaSeylani
Copy link
Contributor

@SinaSeylani SinaSeylani commented Aug 29, 2024

Pull Request Template

What's New?

To better align with the iOS code:

The PassageToken class has been removed.
Functions in the Hosted and Social classes have been renamed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jira Ticket

Please add the Jira ticket number and link.

Copy link
Collaborator

@rickycpadilla rickycpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add integration tests for these new methods?

Copy link
Collaborator

@rickycpadilla rickycpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests, looks great!

Copy link

@SinaSeylani SinaSeylani merged commit de21fa8 into main Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants