-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSG-4798 #79
PSG-4798 #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some changes in the generated code that I assume would impact non-openapi code, but I don't see any updates except in the generated code. Are you sure we don't need to change anything else?
Examples:
UserMetaDataResponse.userMetadata
is now optionalCredentialAssertionChallenge.handshake
andAuthenticateWebAuthnStartWithTransactionResponse.handshake
class changed- Create user response changed
Regarding the SonarCloud quality gate failure - you can exclude the generated code from analysis. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Pull Request Template
What's New?
generated code is updated
Type of change
Checklist:
Jira Ticket
Please add the Jira ticket number and link.