Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unit tests that are already covered by the e2e suite #41

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 27, 2025

What's New?

  • removes mock unit tests that are already covered in the e2e workflow
  • removes example server

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wasn't sure if there was an additional use for the example server or not. i can see it both ways, so if it's preferred that this stay in i will revert its removal

@@ -68,6 +68,3 @@ impl PassageFlex {
self.auth.configuration.base_path = format!("{}/v1/apps/{}", server_url, self.app_id);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left the set_server_url method in because the default base path needs to be updated with the app id:

base_path: "https://api.passage.id/v1/apps/TODO".to_owned(),

@ctran88 ctran88 marked this pull request as ready for review January 27, 2025 21:59
@ctran88 ctran88 merged commit 99581f3 into main Jan 28, 2025
6 checks passed
@ctran88 ctran88 deleted the PSG-4991-remove-e2e-tests branch January 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants