Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psg 4891 Use repo templates in passage-flutter #82

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

jenn-macfarlane
Copy link
Contributor

@jenn-macfarlane jenn-macfarlane commented Oct 18, 2024

Pull Request Template

What's New?

Uses repo templates to format README, LICENSE, and remove community files in favour of using organization community files.

Screenshots (if appropriate):

(Note Passage logo will adhere to system theme, screenshot taken from vscode preview)
CleanShot 2024-10-18 at 12 08 44@2x

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jira Ticket

Please add the Jira ticket number and link.

Additional context

Add any other context or screenshots about the pull request here.

| ---------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| ![Passkey Flex](https://storage.googleapis.com/passage-docs/github-md-assets/passage-passkey-flex-icon.png) Passkey **Flex** | ✖️ For Passkey Flex, check out the [Passkey Flex APIs](https://docs.passage.id/flex/apis) |
| ![Passkey Complete](https://storage.googleapis.com/passage-docs/github-md-assets/passage-passkey-complete-icon.png) Passkey **Complete** | ✅ |
| ![Passkey Ready](https://storage.googleapis.com/passage-docs/github-md-assets/passage-passkey-ready-icon.png) Passkey **Ready** | ✖️ For Passkey Ready, check out [Authentikit for Android](https://github.com/passageidentity/passage-android/tree/main/authentikit) and [Authentikit for iOS](https://github.com/passageidentity/passage-authentikit-ios) |
Copy link
Contributor Author

@jenn-macfarlane jenn-macfarlane Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? Do we want to link to mobile-specific versions of Authentikit here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@agebhardt
Copy link

agebhardt commented Oct 18, 2024

@jenn-macfarlane there is a Passage logo that works in the template. Can that not be used here for some reason?

Just kidding. I didn't understand that this was within VS Code! 🤦🏼 looks great!

@jenn-macfarlane
Copy link
Contributor Author

@rickycpadilla any idea why these integration tests for android would be failing? I can't think of why my changes would cause this 🤔

CleanShot 2024-10-18 at 12 49 24@2x

@jenn-macfarlane
Copy link
Contributor Author

Waiting to merge until the Android ticket is done. Reason being this way I will have a README for Android/authentikit to link to in the products comparison table instead of just the folder in github.

@jenn-macfarlane jenn-macfarlane changed the title Psg 4891 repo templates Psg 4891 Use repo templates in passage-flutter Oct 18, 2024
Copy link

@jenn-macfarlane jenn-macfarlane merged commit 096f79a into main Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants