Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK updates #118

Merged
merged 14 commits into from
Mar 25, 2024
Merged

SDK updates #118

merged 14 commits into from
Mar 25, 2024

Conversation

passage-beachball-bot
Copy link
Contributor

No description provided.

@tdeshong tdeshong requested a review from ctran88 March 22, 2024 19:59
@ctran88
Copy link
Contributor

ctran88 commented Mar 22, 2024

The following changes are needed to export the types correctly:

The addition of an index file at src/models/index.ts to export the deprecated models

diff --git a/src/models/index.ts b/src/models/index.ts
new file mode 100644
index 0000000..0a6a522
--- /dev/null
+++ b/src/models/index.ts
@@ -0,0 +1,4 @@
+/* tslint:disable */
+/* eslint-disable */
+export * from './UpdateMagicLinkAuthMethod';
+export * from './UpdateOtpAuthMethod';

and the re-export of that new index file in src/index.ts

diff --git a/src/index.ts b/src/index.ts
index a937ac2..3ea2c82 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -5,6 +5,7 @@ export * from './types/MagicLink';
 export * from './types/PassageConfig';
 export * from './types/User';
 export * from './generated/models';
+export * from './models';
 export {
     AppInfo as AppObject,
     CreateUserRequest as CreateUserPayload,
@@ -17,7 +18,6 @@ export {
     Layouts,
     LayoutConfig,
     ResponseError,
-    UserEventInfo,    <-- this one seems to have been broken since the last release https://github.com/passageidentity/passage-node/pull/109
     UserMetadataFieldType,
     UserMetadataField,
     WebAuthnDevices,

@ctran88
Copy link
Contributor

ctran88 commented Mar 22, 2024

Oh I'm sorry I forgot to mention in my last comment that one of the models was missed: git ended up resolving the diff between src/generated/models/UpdatePasskeysAuthMethod.ts and src/generated/models/Link.ts as a rename instead of a delete & add new file.

So UpdatePasskeysAuthMethod.ts needs to be added the deprecated models.

Copy link

Quality Gate Passed Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@tdeshong tdeshong merged commit 679d2be into main Mar 25, 2024
2 checks passed
@tdeshong tdeshong deleted the sdk-updates-1711035742 branch March 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants