fix(app): replace Set.intersection() with filter for broad browser compat - #3938
Merged
calebtuttle merged 1 commit intoAug 28, 2026
Merged
Conversation
Set.prototype.intersection() is only available in Chrome 122+, Firefox 127+, and Safari 17+. Users on older browsers hit an uncaught TypeError that crashes the entire dashboard (no error boundary exists to contain it). Replaces the call in PlatformCard with a .some()/.has() loop, which has universal Set support. Fixes holonym-foundation/internal-docs#2630 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformCard.tsxcalledSet.prototype.intersection(), which is only available in Chrome ≥122, Firefox ≥127, Safari ≥17 — any older browser throws an uncaughtTypeError[...onchainProviderSet].some(p => providerSet.has(p))— equivalent logic, universal compatibilityEvidence (Datadog, passport-prod, 7d)
130 error events / 6 sessions / 5 countries (JP, LT, MA, RU, CH) — every sampled browser version (Chrome 109, Iron 118, Chrome 120) is below the real support cutoffs, confirmed via MDN browser-compat-data.
Fixes holonym-foundation/internal-docs#2630
Test plan
PlatformCardstill correctly marks stamps as on-chain whenactiveChainProvidersoverlaps withplatformProviders🤖 Generated with Claude Code