feat: Add ability to configure host IP during tesseract serve#185
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 76.25% 76.21% -0.04%
==========================================
Files 28 28
Lines 3062 3078 +16
Branches 476 480 +4
==========================================
+ Hits 2335 2346 +11
- Misses 517 519 +2
- Partials 210 213 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This looks good so far, and I think an explicit design is better than implicit. However, I did want to highlight the possibility of having this all configured by |
Contributor
Author
|
Yes let's not overload the port argument any more than it already is :) |
dionhaefner
marked this pull request as ready for review
June 3, 2025 21:24
xalelax
approved these changes
Jun 4, 2025
dionhaefner
enabled auto-merge (squash)
June 4, 2025 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
n/a
Description of changes
127.0.0.1(localhost) by default when usingtesseract-runtime serve, to avoid accidentally exposing Tesseracts to the local or public internet when usingtesseract-runtimedirectly.tesseract serve.To-do:
Testing done
CI + manual