Skip to content

fix: sanitize all config fields passed as envvars to dockerfile#187

Merged
xalelax merged 2 commits into
mainfrom
dion/sanitize-config
Jun 4, 2025
Merged

fix: sanitize all config fields passed as envvars to dockerfile#187
xalelax merged 2 commits into
mainfrom
dion/sanitize-config

Conversation

@dionhaefner

Copy link
Copy Markdown
Contributor

Relevant issue or PR

Fixes #186

Description of changes

  • Strip newlines and quotes from config interpolated into Dockerfile

Testing done

manual

@dionhaefner dionhaefner changed the title sanitize all config fields passed as envvars to dockerfile fix: sanitize all config fields passed as envvars to dockerfile Jun 4, 2025
@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (d2ab395) to head (74ce001).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files          28       28           
  Lines        3078     3078           
  Branches      480      480           
=======================================
  Hits         2346     2346           
  Misses        519      519           
  Partials      213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xalelax xalelax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xalelax
xalelax merged commit 0ce8a03 into main Jun 4, 2025
35 checks passed
@xalelax
xalelax deleted the dion/sanitize-config branch June 4, 2025 14:09
@pasteurlabs pasteurlabs locked and limited conversation to collaborators Jun 4, 2025
@johnbcoughlin

Copy link
Copy Markdown
Contributor

Amazing, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate/parse YAML before passing to Docker

3 participants