Skip to content

fix: Always become root at the start of docker builds#598

Merged
dionhaefner merged 2 commits into
mainfrom
dion/auto-root
May 23, 2026
Merged

fix: Always become root at the start of docker builds#598
dionhaefner merged 2 commits into
mainfrom
dion/auto-root

Conversation

@dionhaefner

Copy link
Copy Markdown
Contributor

Relevant issue or PR

n/a

Description of changes

Currently, builds fail during apt-get when base images set a non-root USER. This fixes it by explicitly acquiring root permissions at the start of every build.

Testing done

None.

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.07%. Comparing base (08a5bf0) to head (792968c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files          32       32           
  Lines        4492     4492           
  Branches      738      738           
=======================================
  Hits         3462     3462           
  Misses        727      727           
  Partials      303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PasteurBot

PasteurBot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Benchmarks use a no-op Tesseract to measure pure framework overhead.

🚀 0 faster, ⚠️ 1 slower, ✅ 35 unchanged

Notable changes

Benchmark Baseline Current Change Status
roundtrip/base64_100,000 0.768ms 0.875ms +14.0% ⚠️ slower
Full results
Benchmark Baseline Current Change Status
api/apply_1,000 0.494ms 0.493ms -0.2%
api/apply_100,000 0.494ms 0.496ms +0.3%
api/apply_10,000,000 0.496ms 0.495ms -0.1%
cli/apply_1,000 1643.217ms 1642.004ms -0.1%
cli/apply_100,000 1656.156ms 1655.592ms -0.0%
cli/apply_10,000,000 1686.067ms 1700.601ms +0.9%
decoding/base64_1,000 0.028ms 0.028ms -0.2%
decoding/base64_100,000 0.605ms 0.634ms +4.8%
decoding/base64_10,000,000 71.639ms 71.588ms -0.1%
decoding/binref_1,000 0.186ms 0.183ms -2.0%
decoding/binref_100,000 0.235ms 0.233ms -0.8%
decoding/binref_10,000,000 9.216ms 9.080ms -1.5%
decoding/json_1,000 0.098ms 0.098ms +0.0%
decoding/json_100,000 9.358ms 9.340ms -0.2%
decoding/json_10,000,000 1114.612ms 1110.952ms -0.3%
encoding/base64_1,000 0.027ms 0.026ms -0.0%
encoding/base64_100,000 0.143ms 0.143ms -0.4%
encoding/base64_10,000,000 23.091ms 22.836ms -1.1%
encoding/binref_1,000 0.277ms 0.275ms -0.8%
encoding/binref_100,000 0.446ms 0.447ms +0.3%
encoding/binref_10,000,000 17.242ms 17.152ms -0.5%
encoding/json_1,000 0.141ms 0.140ms -1.1%
encoding/json_100,000 14.856ms 14.461ms -2.7%
encoding/json_10,000,000 1508.250ms 1529.192ms +1.4%
http/apply_1,000 2.918ms 2.892ms -0.9%
http/apply_100,000 8.113ms 8.112ms -0.0%
http/apply_10,000,000 669.128ms 670.642ms +0.2%
roundtrip/base64_1,000 0.055ms 0.054ms -1.8%
roundtrip/base64_100,000 0.768ms 0.875ms +14.0% ⚠️ slower
roundtrip/base64_10,000,000 94.598ms 94.932ms +0.4%
roundtrip/binref_1,000 0.473ms 0.472ms -0.2%
roundtrip/binref_100,000 0.691ms 0.686ms -0.8%
roundtrip/binref_10,000,000 26.622ms 26.621ms -0.0%
roundtrip/json_1,000 0.247ms 0.245ms -0.8%
roundtrip/json_100,000 21.617ms 20.975ms -3.0%
roundtrip/json_10,000,000 2629.086ms 2623.008ms -0.2%
  • Runner: Linux 6.17.0-1013-azure x86_64

@jpbrodrick89 jpbrodrick89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dionhaefner
dionhaefner merged commit 9d1512b into main May 23, 2026
52 checks passed
@dionhaefner
dionhaefner deleted the dion/auto-root branch May 23, 2026 15:49
@pasteurlabs pasteurlabs locked and limited conversation to collaborators May 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants