chore: fix bump workflow lockfile generation#640
Merged
Conversation
dionhaefner
requested review from
apaleyes,
jpbrodrick89 and
xalelax
as code owners
July 13, 2026 12:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
=======================================
Coverage 78.03% 78.03%
=======================================
Files 39 39
Lines 4685 4685
Branches 770 770
=======================================
Hits 3656 3656
Misses 720 720
Partials 309 309 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dionhaefner
force-pushed
the
fix/bump-lockfile-hook-consistency
branch
from
July 13, 2026 12:18
0ca11a8 to
8995b89
Compare
The Bump UV lockfile workflow regenerated the lockfile directly with the workflow's (unpinned) uv, while the update-uv-env pre-commit hook that CI validates against pins uv==0.11.21. uv 0.11.26 changed platform-marker output syntax, so the two produced different lockfiles and the pre-commit CI check failed on bump PRs. Adopt the same approach as the internal repos: remove production.uv.lock and regenerate it via the pinned pre-commit hooks, so bot and CI use the same uv. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dionhaefner
force-pushed
the
fix/bump-lockfile-hook-consistency
branch
from
July 13, 2026 12:25
8995b89 to
a912b4f
Compare
jpbrodrick89
approved these changes
Jul 13, 2026
jpbrodrick89
left a comment
jpbrodrick89
left a comment
Contributor
There was a problem hiding this comment.
Same comment as for tesseract-torch:
This is good in isolation by we might want to look at revisiting the way we handle the pin on update-uv-env (this should get bumped periodically, but I'm not sure if any of our actions do)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Bump UV lockfileworkflow regeneratedproduction.uv.lockdirectly with the workflow's uv (astral-sh/setup-uv@v7), while theupdate-uv-envpre-commit hook that CI validates against pinsuv==0.11.21. uv 0.11.26 changed how platform markers are emitted, so the bot-committed lockfile and the CI-regenerated one differed, failing thepre-commitcheck on bump PRs.Fix
Adopt the same approach the internal repos already use: remove
production.uv.lockand regenerate it through the pinned pre-commit hooks, instead of callinguv lockwith the workflow's own uv. Bot and CI now use the same uv version.