Skip to content

Conversation

@rTreutlein
Copy link
Collaborator

No description provided.

Copy link
Owner

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm maybe that should better go into lib_prolog together with the static-import! functionality that is there to load large S expression files without functions and bangs fast. Also absolute paths are probably not needed, that isn't portable to other's computers. Also not sure if we need library explicitly. If they would be handled differently than imports I would understand it, but if it's the same why bother with extra handling?

@rTreutlein
Copy link
Collaborator Author

I moved it to lib_prolog

@rTreutlein
Copy link
Collaborator Author

Can now import fais_ffi but needs patham9/faiss_ffi#1

@patham9
Copy link
Owner

patham9 commented Dec 5, 2025

TODO library as a separate PR with test, as that feature is useful.

And we definitely can have git-import in lib-prolog once it is working (currently not).

@patham9 patham9 added this to the v0.8 milestone Dec 7, 2025
@patham9 patham9 changed the title Import via library or git path Import via library Dec 8, 2025
@patham9
Copy link
Owner

patham9 commented Dec 11, 2025

Hm for larger dependencies we can just use !(import! &self (library dependencyname lib_name)) e.g. for FAISS: !(import! &self (library faiss_ffi lib_faiss)).

Copy link
Owner

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's merge it.

@patham9 patham9 merged commit 9113440 into main Dec 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants