-
Notifications
You must be signed in to change notification settings - Fork 22
Import via library #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm maybe that should better go into lib_prolog together with the static-import! functionality that is there to load large S expression files without functions and bangs fast. Also absolute paths are probably not needed, that isn't portable to other's computers. Also not sure if we need library explicitly. If they would be handled differently than imports I would understand it, but if it's the same why bother with extra handling?
|
I moved it to lib_prolog |
|
Can now import fais_ffi but needs patham9/faiss_ffi#1 |
|
TODO library as a separate PR with test, as that feature is useful. And we definitely can have git-import in lib-prolog once it is working (currently not). |
77f7d59 to
966391d
Compare
|
Hm for larger dependencies we can just use |
patham9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's merge it.
No description provided.