You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The hyphen-to-underscore replacement may cause issues if the receiving system expects the original server name format or if there are dependencies on the original naming convention elsewhere in the codebase.
The code assumes server.name exists and is a string, but there's no validation to handle cases where server.name might be null, undefined, or not a string before applying the replace method.
The global replacement of all hyphens with underscores may cause issues if the server name contains legitimate hyphens that should be preserved. Consider validating the server name format or using a more targeted replacement approach.
Why: The suggestion raises a valid point that globally replacing all hyphens might have unintended side effects, prompting the developer to reconsider the requirements for this sanitization.
Replaces dashes (-) with underscores (_) in server.name before adding it to the name query-param inside pages/registry/index.html, ensuring the generated deeplink works correctly.
Review
Looks good – concise change targeting the bug without side effects.
Matches the format used elsewhere for name (avoids breaking deeplink parsing).
No build/runtime impact outside the query-string.
Consider adding a short comment or utility helper if similar transformations are needed in other places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix
Description
Changes diagram
Changes walkthrough 📝
index.html
Fix server name hyphen replacementpages/registry/index.html