Skip to content

Add new fasting amount and related qualities#590

Closed
rays22 wants to merge 1 commit into
masterfrom
issue589
Closed

Add new fasting amount and related qualities#590
rays22 wants to merge 1 commit into
masterfrom
issue589

Conversation

@rays22

@rays22 rays22 commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

This commit intends to add new classes

  1. PATO:0103007 'fasting amount'
  2. PATO:0103008 'increased fasting amount'
  3. PATO:0103009 'decreased fasting amount'

If applied, this commit will fix #589.

This commit intends to add new classes
1.  PATO:0103007 'fasting amount'
2.  PATO:0103008 'increased fasting amount'
3.  PATO:0103009 'decreased fasting amount'

If applied, this commit will fix #589.
@rays22 rays22 self-assigned this Aug 22, 2025
@rays22 rays22 requested review from ar-ibrahim and matentzn August 22, 2025 17:07

@matentzn matentzn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some more time to consider this. When I saw this on the OBA tracker it looker straight forward but now I am not so sure if "amount while X" characteristic where X is a physiological state will just be a bottomless pit again. "exercising amount", "sleeping amount" etc ect. Gimme 2, 3 days. If the terms in OBA cant wait, just tell Aleix to add them without an EQ (but classify them somewhere reasonable)

intersection_of: PATO:0103007 ! fasting amount
intersection_of: RO:0015008 PATO:0000461 ! decreased in magnitude relative to normal
property_value: http://purl.org/dc/elements/1.1/date "2025-08-22T16:43:06Z" xsd:dateTime
property_value: http://www.geneontology.org/formats/oboInOwl#http://purl.org/dc/terms/contributor https://orcid.org/0000-0001-8314-2140

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong property used.

@aleixpuigb

Copy link
Copy Markdown
Contributor

@matentzn I am not in a hurry. Thank you for reviewing and commenting (here and in slack)!

@matentzn

Copy link
Copy Markdown
Contributor

@aleixpuigb can you decide how to proceed with this PR? OR close it?

@aleixpuigb

Copy link
Copy Markdown
Contributor

We end up with a different solution creating a new pattern in OBa (see obophenotype/bio-attribute-ontology#394 PR can be closed (I don't have the rights to do it). Thank you!

@matentzn

Copy link
Copy Markdown
Contributor

#590 (comment)

@matentzn matentzn closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NTR] fasting amount

3 participants