Implement Normal, a solver applying an inner solver to the normal equations#159
Merged
patrick-kidger merged 1 commit intopatrick-kidger:devfrom Dec 5, 2025
Merged
Conversation
c59fa0d to
122f8de
Compare
122f8de to
fef2316
Compare
fef2316 to
5448d65
Compare
Owner
|
Looks like the test failures are from #172 and unrelated, so merging! |
Merged
patrick-kidger
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #157 by implementing what we discussed there, a wrapper which takes any solver and applies it to the normal equations.
I've stacked this change atop #158 as the implementation is significantly cleaner taken with the change there.
This currently includes the breaking change of removing
lx.NormalCG(...)in favor oflx.Normal(lx.CG(...)), so perhaps a simple definition should be made for backward compatibility. It was not clear how I should handle that from the standpoint of the documentation, as the following sufficesbut now the name NormalCG is a function, not a class, and its not clear if it be documented along with the other solvers. Would you want to add the above as an alternative, possibly deprecated interface? And if so should it be documented, and if so how?