Fixes for preconditioned krylov solvers#162
Merged
patrick-kidger merged 1 commit intopatrick-kidger:mainfrom Jun 27, 2025
Merged
Fixes for preconditioned krylov solvers#162patrick-kidger merged 1 commit intopatrick-kidger:mainfrom
patrick-kidger merged 1 commit intopatrick-kidger:mainfrom
Conversation
Contributor
f0uriest
commented
Jun 16, 2025
f0uriest
commented
- Uses transpose/conjugate preconditioner for transpose/conjugate linear solve for backwards pass. Previously the preconditioner was discarded in these cases leading to convergence issues. (Preconditioner for transposed krylov methods #160)
- Clarifies some docstrings about the type of preconditioning used, and requirements the preconditioner must satisfy. (Clarification on docstrings for preconditioners #139)
- Uses transpose/conjugate preconditioner for transpose/conjugate linear solve for backwards pass. Previously the preconditioner was discarded in these cases leading to convergence issues. - Clarifies some docstrings about the type of preconditioning used, and requirements the preconditioner must satisfy.
Owner
|
Okay, awesome -- this all LGTM! (I think I see some fixes for the NormalCG case in there too :) ) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.