Early validation of jac argument of `JacobianLinearOperator#167
Merged
patrick-kidger merged 2 commits intopatrick-kidger:mainfrom Jun 28, 2025
Merged
Conversation
Owner
patrick-kidger
left a comment
patrick-kidger
left a comment
There was a problem hiding this comment.
Thank you for this! Nits aside this LGTM.
As for Ruff, it pretty-formats using the Wadler-Lindig algorithm internally; this leads to a waterfall-then-horizontal approach to laying things out.
Owner
|
Awesome, LGTM! Thanks for the contribution, and merged :) |
jpbrodrick89
added a commit
to jpbrodrick89/lineax
that referenced
this pull request
Jan 27, 2026
…k-kidger#167) * Early validation of `jac` argument of `JacobianLinearOperator * address nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #166 the static
jackwarg ofJacobianLinearOperatoris now validated in__init__to fail fast. Should I remove the later validation in the methods? My gut feel is it's safer to keep them in, just in caseself.jacis incorrectly modified.PS I'm not sure why
ruffrelinted in the way it did, my initial draft was:but it got re-formatted.